Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration Mapper #333

Merged
merged 42 commits into from
Jul 31, 2020
Merged

Configuration Mapper #333

merged 42 commits into from
Jul 31, 2020

Conversation

radcortez
Copy link
Member

@radcortez radcortez commented Jun 17, 2020

@dmlloyd let me know if you think this is going into the right direction.

There is still a lot of things to take care and to try. Here are a few things that I did:

  • Optional registration of class mappers in the SmallRyeBuilder for proper validation.
  • When a root cannot be found, one is created on the fly (experimental, I need to think better about this. We may want to merge with the current one).
  • Support JavaBeans getter style method names
  • Validation is only done for properties that have a registered root. For instance if we register the root server, we only validate the server namespace.
  • Moved standalone API's to main package and rename annotations for consistency.
  • Support empty root prefix.
  • Use SmallRyeConfigs Default Values API.
  • Fixes around Optional / Map mapping.

There is still a lot of things to work on (which I'm happy to do):

@radcortez radcortez changed the title Support ConfigValue injection. Configuration Mapper Jun 17, 2020
@radcortez radcortez force-pushed the mapper branch 2 times, most recently from 1fd8a4f to d7906e1 Compare June 30, 2020 20:04
@radcortez
Copy link
Member Author

@dmlloyd I've tried to fix some of the issues that I've found and write some additional tests. I believe this is going into the right track, but please let me know what do you think.

@radcortez radcortez requested a review from dmlloyd June 30, 2020 20:12
@radcortez radcortez mentioned this pull request Jun 30, 2020
@radcortez
Copy link
Member Author

@dmlloyd do you think we are ready to merge this and work the remaining pieces in subsequents PR's?

@radcortez radcortez force-pushed the mapper branch 2 times, most recently from d2e094f to f8c171d Compare July 31, 2020 15:30
@radcortez
Copy link
Member Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants